[
https://issues.apache.org/jira/browse/HIVE-24880?focusedWorklogId=568178&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568178
]
ASF GitHub Bot logged work on HIVE-24880:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/21 08:50
Start Date: 18/Mar/21 08:50
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2079:
URL: https://github.com/apache/hive/pull/2079#discussion_r596657330
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -4638,8 +4649,8 @@ public GetPartitionsResponse
getPartitionsWithSpecs(GetPartitionsRequest request
}
@Override
- public OptionalCompactionInfoStruct findNextCompact(String workerId) throws
MetaException, TException {
- return client.find_next_compact(workerId);
+ public OptionalCompactionInfoStruct findNextCompact(String workerId, String
workerVersion) throws MetaException, TException {
Review comment:
I am not sure we could retire public API like this upstream. Not 100%
sure, but I think we should keep prev method signature as well but mark it as
deprecated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 568178)
Time Spent: 3h 40m (was: 3.5h)
> Add host and version information to compection queue
> ----------------------------------------------------
>
> Key: HIVE-24880
> URL: https://issues.apache.org/jira/browse/HIVE-24880
> Project: Hive
> Issue Type: Sub-task
> Reporter: Peter Varga
> Assignee: Peter Varga
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> The Initiator host and version should be added to compaction and completed
> compaction queue.
> The worker version should be added to compaction and completed compaction
> queue.
> They should be available in sys tables and view.
> The version should come from the runtime version (not the schema):
> Initiator.class.getPackage().getImplementationVersion() works on clusters
> (hive exec has manifest), might not work in unit tests.
> This would make it possible to create checks on use cases like these:
> * multiple hosts are running Initiator
> ** in some scenarios with different runtime verion
> * the worker and initiator runtime version are not the same
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
