[
https://issues.apache.org/jira/browse/HIVE-24855?focusedWorklogId=571050&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-571050
]
ASF GitHub Bot logged work on HIVE-24855:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/21 10:22
Start Date: 24/Mar/21 10:22
Worklog Time Spent: 10m
Work Description: kasakrisz commented on a change in pull request #2046:
URL: https://github.com/apache/hive/pull/2046#discussion_r600346818
##########
File path: ql/src/test/queries/clientpositive/fetch_deleted_rows.q
##########
@@ -0,0 +1,48 @@
+set hive.support.concurrency=true;
+set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
+SET hive.vectorized.execution.enabled=false;
+
+create table t1(a int, b varchar(128)) stored as orc tblproperties
('transactional'='true');
+
+insert into t1(a,b) values (1, 'one'), (2, 'two');
+
+delete from t1 where a = 1;
+
+insert into t1(a,b) values (3, 'three'), (4, 'four'), (4, 'four again'), (5,
'five');
+
+alter table t1 set tblproperties ('acid.fetch.deleted.rows'='true');
+select t1.ROW__IS__DELETED, * from t1;
Review comment:
When the logical plan is built from the AST and `HiveTableScans` are
instantiated table properties defined in the AST are lost.
When the optimized logical plan is converted back to AST only properties
coming from Druid and JDBC scans are populated. We could add additional
properties from `HiveTableScans` in the same way.
I think passing `acid.fetch.deleted.rows` as a table property in the query
is a good idea and we can benefit from it when building an Incremental MV
rebuild plan. I will try to include this into
[HIVE-24854](https://issues.apache.org/jira/browse/HIVE-24854)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 571050)
Time Spent: 1.5h (was: 1h 20m)
> Introduce virtual colum ROW__IS__DELETED
> ----------------------------------------
>
> Key: HIVE-24855
> URL: https://issues.apache.org/jira/browse/HIVE-24855
> Project: Hive
> Issue Type: New Feature
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
