[
https://issues.apache.org/jira/browse/HIVE-24935?focusedWorklogId=571658&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-571658
]
ASF GitHub Bot logged work on HIVE-24935:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/21 05:49
Start Date: 25/Mar/21 05:49
Worklog Time Spent: 10m
Work Description: kasakrisz opened a new pull request #2118:
URL: https://github.com/apache/hive/pull/2118
### What changes were proposed in this pull request?
1. Remove outdated comment lines and if condition which was moved to
`QBSubQueryParseInfo` and implementations of `ExprFactory.createSubqueryExpr`
2. Renamed boolean variable `noImplicityGby` -> `hasExplicitGby` and negate
its semantics.
### Why are the changes needed?
Code cleanup. This is a follow-up of: #2039
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
```
mvn test -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver
-Dqfile=subquery_full_aggregate.q -pl itests/qtest -Pitests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 571658)
Remaining Estimate: 0h
Time Spent: 10m
> Remove outdated check for correlated exists subqueries with full aggregate
> --------------------------------------------------------------------------
>
> Key: HIVE-24935
> URL: https://issues.apache.org/jira/browse/HIVE-24935
> Project: Hive
> Issue Type: Improvement
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Since HIVE-24929 QBSubQuery.subqueryRestrictionsCheck is no longer called.
> Check for exists subqueries with full aggregate moved to
> QBSubQueryParseInfo.hasFullAggregate() and QBSubQueryParseInfo.getOperator()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
