[
https://issues.apache.org/jira/browse/HIVE-24955?focusedWorklogId=574122&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-574122
]
ASF GitHub Bot logged work on HIVE-24955:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/21 12:39
Start Date: 30/Mar/21 12:39
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2132:
URL: https://github.com/apache/hive/pull/2132#discussion_r604058028
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestCompactionMetrics.java
##########
@@ -444,6 +457,36 @@ public void testDBMetrics() throws Exception {
Assert.assertEquals(1,
Metrics.getOrCreateGauge(MetricsConstants.COMPACTION_STATUS_PREFIX +
"txn_to_writeid").intValue());
+
+ start = System.currentTimeMillis() - 1000L;
Review comment:
em, why do you need to subtract 1s here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 574122)
Time Spent: 1h 10m (was: 1h)
> New metrics about aborted transactions
> --------------------------------------
>
> Key: HIVE-24955
> URL: https://issues.apache.org/jira/browse/HIVE-24955
> Project: Hive
> Issue Type: Sub-task
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> 5 new metrics:
> * Number of aborted transactions in the TXNS table (collected in
> AcidMetricsService)
> * Oldest aborted transaction (collected in AcidMetricsService)
> * Number of aborted write transaction (incremented counter at
> abortTransaction)
> * Number of committed write transaction (incremented counter at
> commitTransaction)
> * Number of timed out transactions (cleaner removed them after heartbeat
> time out)
> The latter 3 will restart as 0 after every HMS restartÂ
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
