[
https://issues.apache.org/jira/browse/HIVE-24909?focusedWorklogId=578135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-578135
]
ASF GitHub Bot logged work on HIVE-24909:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/21 05:35
Start Date: 07/Apr/21 05:35
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2101:
URL: https://github.com/apache/hive/pull/2101#discussion_r608352021
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -8400,8 +8408,10 @@ public void commit_txn(CommitTxnRequest rqst) throws
TException {
}
getTxnHandler().commitTxn(rqst);
if (listeners != null && !listeners.isEmpty()) {
- MetaStoreListenerNotifier.notifyEvent(listeners, EventType.COMMIT_TXN,
- new CommitTxnEvent(rqst.getTxnid(), this));
+ if (!isHiveReplTxn) {
+ MetaStoreListenerNotifier.notifyEvent(listeners, EventType.COMMIT_TXN,
+ new CommitTxnEvent(rqst.getTxnid(), this));
+ }
Review comment:
if (!isHiveReplTxn) can be moved out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 578135)
Time Spent: 4h 20m (was: 4h 10m)
> Skip the repl events from getting logged in notification log
> ------------------------------------------------------------
>
> Key: HIVE-24909
> URL: https://issues.apache.org/jira/browse/HIVE-24909
> Project: Hive
> Issue Type: Bug
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Currently REPL dump events are logged and replicated as a part of replication
> policy. Whenever one replication cycle completed, we always have one
> transaction left open on the target corresponding to repl dump operation.
> This will never be caught up without manually dealing with the transaction on
> target cluster.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
