[
https://issues.apache.org/jira/browse/HIVE-24524?focusedWorklogId=581692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581692
]
ASF GitHub Bot logged work on HIVE-24524:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/21 11:00
Start Date: 13/Apr/21 11:00
Worklog Time Spent: 10m
Work Description: abstractdog commented on a change in pull request #1778:
URL: https://github.com/apache/hive/pull/1778#discussion_r612343543
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java
##########
@@ -797,16 +803,17 @@ public void messageReceived(ChannelHandlerContext ctx,
MessageEvent evt)
Map<String, MapOutputInfo> mapOutputInfoMap =
new HashMap<String, MapOutputInfo>();
- Channel ch = evt.getChannel();
-
+ Channel ch = ctx.channel();
// In case of KeepAlive, ensure that timeout handler does not close
connection until entire
// response is written (i.e, response headers + mapOutput).
- ChannelPipeline pipeline = ch.getPipeline();
+ ChannelPipeline pipeline = ch.pipeline();
TimeoutHandler timeoutHandler =
(TimeoutHandler)pipeline.get(TIMEOUT_HANDLER);
timeoutHandler.setEnabledTimeout(false);
String user = userRsrc.get(jobId);
-
+ if (keepAliveParam || connectionKeepAliveEnabled){
Review comment:
okay, in this case I'll have to include some unit tests here (which
might be part of tez code already) + create a simple repro to share with netty
community
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 581692)
Time Spent: 2h 10m (was: 2h)
> LLAP ShuffleHandler: upgrade to netty4
> --------------------------------------
>
> Key: HIVE-24524
> URL: https://issues.apache.org/jira/browse/HIVE-24524
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Tez already has a WIP patch for upgrading its shuffle handler to netty4.
> Netty4 is told to be a possible performance improvement compared to Netty3.
> However, the refactor is not trivial, TEZ-4157 covers that more or less (the
> code bases are very similar).
> Background:
> netty4 migration guideline:
> https://netty.io/wiki/new-and-noteworthy-in-4.0.html
> articles of possible performance improvement:
> https://blog.twitter.com/engineering/en_us/a/2013/netty-4-at-twitter-reduced-gc-overhead.html
> https://developer.squareup.com/blog/upgrading-a-reverse-proxy-from-netty-3-to-4/
> some other notes: Netty3 is EOL since 2016:
> https://netty.io/news/2016/06/29/3-10-6-Final.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
