[
https://issues.apache.org/jira/browse/HIVE-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950048#comment-14950048
]
Lefty Leverenz commented on HIVE-12066:
---------------------------------------
Shouldn't the patch be attached to this issue? (Commit
cf76e6b5d89dfa2d44b96c852a10ccd0252a4fe8.)
> Add javadoc for methods added to public APIs
> --------------------------------------------
>
> Key: HIVE-12066
> URL: https://issues.apache.org/jira/browse/HIVE-12066
> Project: Hive
> Issue Type: Sub-task
> Reporter: Owen O'Malley
> Assignee: Sergey Shelukhin
> Fix For: llap
>
>
> Looking through the changes for ORC, there are methods being added without
> documentation:
> {code}
> --- ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java
> +++ ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java
> @@ -360,8 +353,18 @@ RecordReader rows(long offset, long length,
> MetadataReader metadata() throws IOException;
> + List<Integer> getVersionList();
> +
> + int getMetadataSize();
> +
> + List<OrcProto.StripeStatistics> getOrcProtoStripeStatistics();
> +
> + List<StripeStatistics> getStripeStatistics();
> +
> + List<OrcProto.ColumnStatistics> getOrcProtoFileStatistics();
> +
> + DataReader createDefaultDataReader(boolean useZeroCopy);
> +
> {code}
> You really need to look through all of the interfaces and fix them before
> merging into master.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
