[
https://issues.apache.org/jira/browse/HIVE-25006?focusedWorklogId=585661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-585661
]
ASF GitHub Bot logged work on HIVE-25006:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/21 09:29
Start Date: 20/Apr/21 09:29
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2161:
URL: https://github.com/apache/hive/pull/2161#discussion_r616510710
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -256,4 +265,74 @@ private static PartitionSpec spec(Schema schema,
Properties properties,
return PartitionSpec.unpartitioned();
}
}
+
+ @Override
+ public void commitInsertTable(org.apache.hadoop.hive.metastore.api.Table
table, boolean overwrite)
+ throws MetaException {
+ String tableName = TableIdentifier.of(table.getDbName(),
table.getTableName()).toString();
+
+ // check status to determine whether we need to commit or to abort
+ JobConf jobConf = new JobConf(conf);
+ String queryIdKey = jobConf.get("hive.query.id") + "." + tableName +
".result";
Review comment:
Makes sense. I was thinking of replacing the query id with a constant
like `HIVE_TEZ_COMMIT_JOB_RESULT` so it would be `HIVE_TEZ_COMMIT_JOB_RESULT +
"." + tableName`, like for job id and task num to make things consisent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 585661)
Time Spent: 1h 10m (was: 1h)
> Commit Iceberg writes in HiveMetaHook instead of TezAM
> ------------------------------------------------------
>
> Key: HIVE-25006
> URL: https://issues.apache.org/jira/browse/HIVE-25006
> Project: Hive
> Issue Type: Task
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Trigger the write commits in the HiveIcebergStorageHandler#commitInsertTable.
> This will enable us to implement insert overwrites for iceberg tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
