[
https://issues.apache.org/jira/browse/HIVE-23820?focusedWorklogId=586338&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-586338
]
ASF GitHub Bot logged work on HIVE-23820:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/21 05:29
Start Date: 21/Apr/21 05:29
Worklog Time Spent: 10m
Work Description: adesh-rao commented on a change in pull request #2153:
URL: https://github.com/apache/hive/pull/2153#discussion_r617206197
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -2381,82 +2381,141 @@ public Partition getPartitionWithAuthInfo(String
catName, String dbName, String
return
deepCopy(FilterUtils.filterPartitionIfEnabled(isClientFilterEnabled,
filterHook, p));
}
+ /**
+ * @deprecated use getTable(GetTableRequest getTableRequest)
+ * @param dbname
+ * @param name
+ * @return
+ * @throws TException
+ */
@Override
+ @Deprecated
public Table getTable(String dbname, String name) throws TException {
- return getTable(getDefaultCatalog(conf), dbname, name);
+ GetTableRequest req = new GetTableRequest(dbname, name);
+ req.setCatName(getDefaultCatalog(conf));
+ return getTable(req);
}
+ /**
+ * @deprecated use getTable(GetTableRequest getTableRequest)
+ * @param dbname
+ * @param name
+ * @param getColumnStats
+ * get the column stats, if available, when true
+ * @param engine engine sending the request
+ * @return
+ * @throws TException
+ */
@Override
+ @Deprecated
public Table getTable(String dbname, String name, boolean getColumnStats,
String engine) throws TException {
- return getTable(getDefaultCatalog(conf), dbname, name, getColumnStats,
engine);
+ GetTableRequest req = new GetTableRequest(dbname, name);
+ req.setCatName(getDefaultCatalog(conf));
+ req.setGetColumnStats(getColumnStats);
+ if (getColumnStats) {
Review comment:
There is no equivalent condition in older code. Why is this done here?
##########
File path:
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java
##########
@@ -3304,14 +3304,20 @@ public Table getTable(String catName, String dbName,
String tableName,
String validWriteIdList) throws TException {
throw new UnsupportedOperationException();
}
-
+
Review comment:
nit: remove indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 586338)
Time Spent: 1h 20m (was: 1h 10m)
> [HS2] Send tableId in request for get_table_request API
> -------------------------------------------------------
>
> Key: HIVE-23820
> URL: https://issues.apache.org/jira/browse/HIVE-23820
> Project: Hive
> Issue Type: Sub-task
> Reporter: Kishen Das
> Assignee: Ashish Sharma
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
