[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=587022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587022
]
ASF GitHub Bot logged work on HIVE-24933:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/21 03:16
Start Date: 22/Apr/21 03:16
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2151:
URL: https://github.com/apache/hive/pull/2151#discussion_r618048430
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
##########
@@ -1406,4 +1439,114 @@ public static Table tableIfExists(ImportTableDesc
tblDesc, Hive db) throws HiveE
}
}
+ public static class LoadTableStateWrapper {
Review comment:
Why are both LoadTableStateWrapper and DelayExecUtil needed? They are
almost alike
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java
##########
@@ -136,4 +140,18 @@ public boolean isOverwrite() {
public void setOverwrite(boolean overwrite) {
this.overwrite = overwrite;
}
+
+ public void setLoadTableStateWrapper(LoadTableStateWrapper
loadTableStateWrapper) {
+ this.loadTableStateWrapper = loadTableStateWrapper;
+ }
+
+ public void setValuesBeforeExec() throws HiveException {
+ if (loadTableStateWrapper == null) {
+ return;
+ }
+
+ Table table = loadTableStateWrapper.getTableIfExists();
Review comment:
CopyWork was generic in nature. setValuesBeforeExec is tying it to
resolve the path only from table. All we need is to be able to resolve the path
dynamically. A resolver interface should be prefered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 587022)
Time Spent: 40m (was: 0.5h)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> ----------------------------------------------------------------------------------------------
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
> Reporter: Pratyushotpal Madhukar
> Assignee: Pratyushotpal Madhukar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
