[
https://issues.apache.org/jira/browse/HIVE-25063?focusedWorklogId=589839&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-589839
]
ASF GitHub Bot logged work on HIVE-25063:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/21 16:04
Start Date: 27/Apr/21 16:04
Worklog Time Spent: 10m
Work Description: kasakrisz opened a new pull request #2227:
URL: https://github.com/apache/hive/pull/2227
### What changes were proposed in this pull request?
Setup null sort order based on the value of the setting
`hive.default.nulls.last` and the order direction when creating ReduceSink
operator for bucketing.
### Why are the changes needed?
Null sort order was setup based on the order direction only which may lead
to unexpected behavior.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Run existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 589839)
Remaining Estimate: 0h
Time Spent: 10m
> Enforce hive.default.nulls.last when enforce bucketing
> ------------------------------------------------------
>
> Key: HIVE-25063
> URL: https://issues.apache.org/jira/browse/HIVE-25063
> Project: Hive
> Issue Type: Bug
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When creating ReduceSink operator for bucketing the sort key null sort order
> is hardcoded:
> {code}
> for (int sortOrder : sortOrders) {
> order.append(DirectionUtils.codeToSign(sortOrder));
> nullOrder.append(sortOrder == DirectionUtils.ASCENDING_CODE ? 'a' :
> 'z');
> }
> {code}
> It should depend on both the setting hive.default.nulls.last and the order
> direction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
