[
https://issues.apache.org/jira/browse/HIVE-12086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951786#comment-14951786
]
Prasanth Jayachandran commented on HIVE-12086:
----------------------------------------------
The reason why this was not done earlier was microbenchmark did not yield
better results for floats directly read from input stream vs buffered reads.
Few comments:
1) Can we do the same for writeFloats?
2) Can you also add the check for EOF in readDouble?
Correctness looks good to me.
> ORC: Buffered float readers to remove vtable thunks
> ---------------------------------------------------
>
> Key: HIVE-12086
> URL: https://issues.apache.org/jira/browse/HIVE-12086
> Project: Hive
> Issue Type: Bug
> Components: File Formats
> Affects Versions: 1.3.0, 2.0.0
> Reporter: Gopal V
> Assignee: Gopal V
> Priority: Minor
> Attachments: HIVE-12086.1.patch
>
>
> ORC float tree reader spends an inordinate amount of time, doing vtable
> thunks through InputStream interface.
> The actual operation is not faster with this patch, but the interface lookup
> goes down ~4x.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
