[ 
https://issues.apache.org/jira/browse/HIVE-24956?focusedWorklogId=595904&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-595904
 ]

ASF GitHub Bot logged work on HIVE-24956:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/May/21 06:29
            Start Date: 13/May/21 06:29
    Worklog Time Spent: 10m 
      Work Description: pkumarsinha commented on a change in pull request #2135:
URL: https://github.com/apache/hive/pull/2135#discussion_r631596465



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/log/IncrementalLoadLogger.java
##########
@@ -33,6 +33,7 @@
   private String dumpDir;
   private long numEvents;
   private long eventSeqNo;
+  private long currentEventTimestamp;

Review comment:
       The concern here is that the timing for first event is not accurate. It 
may be quite a while from the point where ReplLoadWork (which is the start time 
for first event in your patch) till it actually get started. And additionally 
this will also impact the other metrics which may add on per type basis in 
future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 595904)
    Time Spent: 1h 10m  (was: 1h)

> Add debug logs for time taken in the incremental event processing
> -----------------------------------------------------------------
>
>                 Key: HIVE-24956
>                 URL: https://issues.apache.org/jira/browse/HIVE-24956
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Arko Sharma
>            Assignee: Arko Sharma
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to