[
https://issues.apache.org/jira/browse/HIVE-25034?focusedWorklogId=597598&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597598
]
ASF GitHub Bot logged work on HIVE-25034:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/21 12:32
Start Date: 17/May/21 12:32
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2243:
URL: https://github.com/apache/hive/pull/2243#discussion_r633488104
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveShell.java
##########
@@ -216,6 +216,9 @@ private HiveConf initializeConf() {
// enables vectorization on Tez
hiveConf.set("tez.mrreader.config.update.properties",
"hive.io.file.readcolumn.names,hive.io.file.readcolumn.ids");
+ // set lifecycle hooks
+ hiveConf.setVar(HiveConf.ConfVars.HIVE_QUERY_LIFETIME_HOOKS,
HiveIcebergCTASHook.class.getName());
Review comment:
I have seen another Iceberg hook already. Maybe we would like to keep
them as a single class?
Maybe even if they are implementing different interfaces? - Just an idea
which I am playing around
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 597598)
Time Spent: 50m (was: 40m)
> Implement CTAS for Iceberg
> --------------------------
>
> Key: HIVE-25034
> URL: https://issues.apache.org/jira/browse/HIVE-25034
> Project: Hive
> Issue Type: New Feature
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
