[
https://issues.apache.org/jira/browse/HIVE-24802?focusedWorklogId=597737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597737
]
ASF GitHub Bot logged work on HIVE-24802:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/21 15:39
Start Date: 17/May/21 15:39
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1998:
URL: https://github.com/apache/hive/pull/1998#discussion_r633643084
##########
File path:
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java
##########
@@ -85,10 +79,7 @@ public synchronized void init(HiveConf hiveConf) {
LogDivertAppender.registerRoutingAppender(hiveConf);
LogDivertAppenderForTest.registerRoutingAppenderIfInTest(hiveConf);
- if (hiveConf.isWebUiQueryInfoCacheEnabled()) {
- historicalQueryInfos = new QueryInfoCache(
- hiveConf.getIntVar(ConfVars.HIVE_SERVER2_WEBUI_MAX_HISTORIC_QUERIES));
- }
+ this.queryInfoCache = new QueryInfoCache(hiveConf);
Review comment:
yes, the cache will only be used when the WebUI is enabled, make it
Optional here.
##########
File path:
service/src/java/org/apache/hive/service/cli/session/SessionManager.java
##########
@@ -281,6 +284,7 @@ private void initOperationLogRootDir() {
LOG.warn("Failed to schedule cleanup HS2 operation logging root dir: "
+
operationLogRootDir.getAbsolutePath(), e);
}
+ logManager = new OperationLogManager(this, hiveConf);
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 597737)
Time Spent: 4h 20m (was: 4h 10m)
> Show operation log at webui
> ---------------------------
>
> Key: HIVE-24802
> URL: https://issues.apache.org/jira/browse/HIVE-24802
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Minor
> Labels: pull-request-available
> Attachments: operationlog.png
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Currently we provide getQueryLog in HiveStatement to fetch the operation log,
> and the operation log would be deleted on operation closing(delay for the
> canceled operation). Sometimes it's would be not easy for the user(jdbc) or
> administrators to deep into the details of the finished(failed) operation, so
> we present the operation log on webui and keep the operation log for some
> time for latter analysis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
