[jira] [Work logged] (HIVE-25152) Remove Superfluous Logging Code

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-25152?focusedWorklogId=600795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600795
 ]

ASF GitHub Bot logged work on HIVE-25152:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/May/21 09:57
            Start Date: 22/May/21 09:57
    Worklog Time Spent: 10m 
      Work Description: pgaref commented on a change in pull request #2310:
URL: https://github.com/apache/hive/pull/2310#discussion_r637382893



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
##########
@@ -1463,15 +1441,11 @@ public Object process(Node nd, Stack<Node> stack, 
NodeProcessorCtx ctx, Object..
           ndRecursive = ndRecursive.getChildren().get(0);
         }
         if (ndRecursive.getChildren().get(0) instanceof ReduceSinkOperator) {
-          if (LOG.isDebugEnabled()) {
-            LOG.debug("Skip JOIN-FIL(*)-RS structure.");
-          }
+          LOG.debug("Skip JOIN-FIL(*)-RS structure.");
           return null;
         }
       }
-      if (LOG.isInfoEnabled()) {
-        LOG.info("Old exprs " + conf.getExprs());
-      }
+      LOG.info("Old exprs " + conf.getExprs());

Review comment:
       Old exprs {}

##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
##########
@@ -1484,18 +1458,14 @@ public Object process(Node nd, Stack<Node> stack, 
NodeProcessorCtx ctx, Object..
         for (ExprNodeDesc expr : exprs) {
           ExprNodeDesc newExpr = foldExpr(expr, constants, cppCtx, op, tag, 
false);
           if (newExpr instanceof ExprNodeConstantDesc) {
-            if (LOG.isInfoEnabled()) {
-              LOG.info("expr " + newExpr + " fold from " + expr + " is 
removed.");
-            }
+            LOG.info("expr " + newExpr + " fold from " + expr + " is 
removed.");

Review comment:
       same

##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
##########
@@ -1484,18 +1458,14 @@ public Object process(Node nd, Stack<Node> stack, 
NodeProcessorCtx ctx, Object..
         for (ExprNodeDesc expr : exprs) {
           ExprNodeDesc newExpr = foldExpr(expr, constants, cppCtx, op, tag, 
false);
           if (newExpr instanceof ExprNodeConstantDesc) {
-            if (LOG.isInfoEnabled()) {
-              LOG.info("expr " + newExpr + " fold from " + expr + " is 
removed.");
-            }
+            LOG.info("expr " + newExpr + " fold from " + expr + " is 
removed.");
             continue;
           }
           newExprs.add(newExpr);
         }
         e.setValue(newExprs);
       }
-      if (LOG.isInfoEnabled()) {
-        LOG.info("New exprs " + conf.getExprs());
-      }
+      LOG.info("New exprs " + conf.getExprs());

Review comment:
       same




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 600795)
    Time Spent: 1h  (was: 50m)

> Remove Superfluous Logging Code
> -------------------------------
>
>                 Key: HIVE-25152
>                 URL: https://issues.apache.org/jira/browse/HIVE-25152
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> So much logging code can be removed to lessen the amount of code in the 
> project (and perhaps some small performance gains).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)