[ 
https://issues.apache.org/jira/browse/HIVE-25128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Mollitor updated HIVE-25128:
----------------------------------
    Description: 
{code:java|title=RawStore.java}
  /**
   * Alter an existing catalog.  Only description and location can be changed, 
and the change of
   * location is for internal use only.
   * @param catName name of the catalog to alter.
   * @param cat new version of the catalog.
   * @throws MetaException something went wrong, usually in the database.
   * @throws InvalidOperationException attempt to change something about the 
catalog that is not
   * changeable, like the name.
   */
  void alterCatalog(String catName, Catalog cat) throws MetaException, 
InvalidOperationException;
{code}

Please check out parent task [HIVE-25126] for the motivation here, but I would 
like to remove all Thrift-based Exceptions from the {{RawStore}} interface to 
include MetaException and InvalidOperationException. These should be replaced 
with something that is specific to Hive and not tied to the RPC layer.

I propose instead introducing RuntimeExceptions called HiveMetaRuntimeException 
and sub-class HiveMetaDataAccessException to replace these.

HiveMetaDataAccessException  = Unable to load data from underlying data store
HiveMetaRuntimeException = Generic exception for something that was thrown by 
the RawStore but not specifically handled

> Remove Thrift Exceptions From RawStore alterCatalog
> ---------------------------------------------------
>
>                 Key: HIVE-25128
>                 URL: https://issues.apache.org/jira/browse/HIVE-25128
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> {code:java|title=RawStore.java}
>   /**
>    * Alter an existing catalog.  Only description and location can be 
> changed, and the change of
>    * location is for internal use only.
>    * @param catName name of the catalog to alter.
>    * @param cat new version of the catalog.
>    * @throws MetaException something went wrong, usually in the database.
>    * @throws InvalidOperationException attempt to change something about the 
> catalog that is not
>    * changeable, like the name.
>    */
>   void alterCatalog(String catName, Catalog cat) throws MetaException, 
> InvalidOperationException;
> {code}
> Please check out parent task [HIVE-25126] for the motivation here, but I 
> would like to remove all Thrift-based Exceptions from the {{RawStore}} 
> interface to include MetaException and InvalidOperationException. These 
> should be replaced with something that is specific to Hive and not tied to 
> the RPC layer.
> I propose instead introducing RuntimeExceptions called 
> HiveMetaRuntimeException and sub-class HiveMetaDataAccessException to replace 
> these.
> HiveMetaDataAccessException  = Unable to load data from underlying data store
> HiveMetaRuntimeException = Generic exception for something that was thrown by 
> the RawStore but not specifically handled



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to