[
https://issues.apache.org/jira/browse/HIVE-25055?focusedWorklogId=601512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601512
]
ASF GitHub Bot logged work on HIVE-25055:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/21 03:17
Start Date: 25/May/21 03:17
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on pull request #2218:
URL: https://github.com/apache/hive/pull/2218#issuecomment-847497433
> Hello. I agree that this section of code needs a lot of help. However, I
think the real issue is that we are throwing these Thrift-exceptions from deep
in Hive core code. I propose that we stop doing that and instead wrap these
Thrift exceptions appropriately as they bubble up from Hive-core. This is
effort highlights yet another issue with working with these Thrift exceptions.
>
> Take a look at https://issues.apache.org/jira/browse/HIVE-25126
Hey, @belugabehr, thank you for the input. As I can see, remove the
Thrift-exceptions from the Hive core is not easy. There are some external
classes that implements the RawStore, for example, the authorizing RawStore,
removing the exceptions will make some incompatible, the retrying Metastore
client uses the exception to make a decision on retrying the current operation,
it's may not easy to transform un-checked Exceptions into Thrift exceptions
appropriately(by message?) and we should move the current throw-if-meet logic
deep in hive core to the HMS Handler. What do you think?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 601512)
Time Spent: 1h 40m (was: 1.5h)
> Improve the exception handling in HMSHandler
> --------------------------------------------
>
> Key: HIVE-25055
> URL: https://issues.apache.org/jira/browse/HIVE-25055
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
