[
https://issues.apache.org/jira/browse/HIVE-25161?focusedWorklogId=602162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-602162
]
ASF GitHub Bot logged work on HIVE-25161:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/21 07:47
Start Date: 26/May/21 07:47
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2316:
URL: https://github.com/apache/hive/pull/2316#discussion_r639481002
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -218,7 +235,15 @@ private static Schema hiveSchemaOrThrow(Properties
serDeProperties, Exception pr
throws SerDeException {
// Read the configuration parameters
String columnNames =
serDeProperties.getProperty(serdeConstants.LIST_COLUMNS);
+ // add partition columns to schema as well, if any
+ if (serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMNS) !=
null) {
+ columnNames = columnNames + "," +
serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMNS);
+ }
String columnTypes =
serDeProperties.getProperty(serdeConstants.LIST_COLUMN_TYPES);
+ // add partition column types to schema as well, if any
+ if
(serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMN_TYPES) !=
null) {
+ columnTypes = columnTypes + ":" +
serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMN_TYPES);
+ }
Review comment:
nit: newline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 602162)
Time Spent: 0.5h (was: 20m)
> Implement CTAS for partitioned Iceberg tables
> ---------------------------------------------
>
> Key: HIVE-25161
> URL: https://issues.apache.org/jira/browse/HIVE-25161
> Project: Hive
> Issue Type: New Feature
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
