[
https://issues.apache.org/jira/browse/HIVE-25157?focusedWorklogId=602320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-602320
]
ASF GitHub Bot logged work on HIVE-25157:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/21 13:11
Start Date: 26/May/21 13:11
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #2312:
URL: https://github.com/apache/hive/pull/2312#discussion_r639710520
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java
##########
@@ -338,15 +330,17 @@ public boolean waitForValidStatus() {
}
// Allow lookup by query string
- private final Map<String, Set<CacheEntry>> queryMap = new HashMap<String,
Set<CacheEntry>>();
+ @GuardedBy("cacheLock")
+ private final Multimap<String, CacheEntry> queryMap = HashMultimap.create();
// LRU. Could also implement LRU as a doubly linked list if CacheEntry keeps
its node.
// Use synchronized map since even read actions cause the lru to get updated.
- private final Map<CacheEntry, CacheEntry> lru = Collections.synchronizedMap(
- new LinkedHashMap<CacheEntry, CacheEntry>(INITIAL_LRU_SIZE,
LRU_LOAD_FACTOR, true));
+ private final Set<CacheEntry> lru =
+ Collections.synchronizedSet(Collections.newSetFromMap(new
LinkedHashMap<>(16, 0.75f, true)));
Review comment:
Use `Set` instead of Map with the same key/value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 602320)
Time Spent: 1.5h (was: 1h 20m)
> Clean up QueryResultsCache Code
> -------------------------------
>
> Key: HIVE-25157
> URL: https://issues.apache.org/jira/browse/HIVE-25157
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> * Remove superfluous code
> * Simplify lock usage (remove instances of {{synchronization}})
> * Simplify code with Guava {{Multimap}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
