[
https://issues.apache.org/jira/browse/HIVE-25141?focusedWorklogId=602425&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-602425
]
ASF GitHub Bot logged work on HIVE-25141:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/21 16:40
Start Date: 26/May/21 16:40
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #2299:
URL: https://github.com/apache/hive/pull/2299#discussion_r639913863
##########
File path: ql/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandler.java
##########
@@ -1692,7 +1692,7 @@ public void testReplOpenTxn() throws Exception {
int numTxn = 50000;
String[] output = TestTxnDbUtil.queryToString(conf, "SELECT
MAX(\"TXN_ID\") + 1 FROM \"TXNS\"").split("\n");
long startTxnId = Long.parseLong(output[1].trim());
- txnHandler.setOpenTxnTimeOutMillis(30000);
+ txnHandler.setOpenTxnTimeOutMillis(60000);
Review comment:
This timeout (failing test) was giving me a lot of heartburn. I have
been playing around with it on `master` branch and it's pretty sensitive to
change. Lowering it just a little causes timeout failures. I have bumped it
here to get it to pass and to make this test less flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 602425)
Time Spent: 50m (was: 40m)
> Review Error Level Logging in HMS Module
> ----------------------------------------
>
> Key: HIVE-25141
> URL: https://issues.apache.org/jira/browse/HIVE-25141
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> * Remove "log *and* throw" (it should be one or the other
> * Remove superfluous code
> * Ensure the stack traces are being logged (and not just the Exception
> message) to ease troubleshooting
> * Remove double-printing the Exception message (SLF4J dictates that the
> Exception message will be printed as part of the logger's formatting
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
