[
https://issues.apache.org/jira/browse/HIVE-25195?focusedWorklogId=606003&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-606003
]
ASF GitHub Bot logged work on HIVE-25195:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/21 15:36
Start Date: 03/Jun/21 15:36
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2347:
URL: https://github.com/apache/hive/pull/2347#discussion_r644899221
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -437,19 +438,13 @@ public void
commitInsertTable(org.apache.hadoop.hive.metastore.api.Table table,
throws MetaException {
String tableName = TableIdentifier.of(table.getDbName(),
table.getTableName()).toString();
JobContext jobContext = getJobContextForCommitOrAbort(tableName,
overwrite);
- boolean failure = false;
- try {
- OutputCommitter committer = new HiveIcebergOutputCommitter();
- committer.commitJob(jobContext);
- } catch (Exception e) {
- failure = true;
- LOG.error("Error while trying to commit job", e);
- throw new MetaException(StringUtils.stringifyException(e));
- } finally {
- // if there's a failure, the configs will still be needed in
rollbackInsertTable
- if (!failure) {
- // avoid config pollution with prefixed/suffixed keys
- cleanCommitConfig(tableName);
+ if (jobContext != null) {
Review comment:
Oh... I found the reason behind it 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 606003)
Time Spent: 0.5h (was: 20m)
> Store Iceberg write commit and ctas information in QueryState
> --------------------------------------------------------------
>
> Key: HIVE-25195
> URL: https://issues.apache.org/jira/browse/HIVE-25195
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We should replace the current method of passing Iceberg write commit-related
> information (jobID, task num) and CTAS info via the session conf using
> prefixed keys. We have a new way of doing that more cleanly, using the
> QueryState object. This should make the code easier to maintain and guard
> against accidental session conf pollution.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
