[
https://issues.apache.org/jira/browse/HIVE-24590?focusedWorklogId=607675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607675
]
ASF GitHub Bot logged work on HIVE-24590:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/21 07:19
Start Date: 07/Jun/21 07:19
Worklog Time Spent: 10m
Work Description: prasanthj commented on a change in pull request #1849:
URL: https://github.com/apache/hive/pull/1849#discussion_r646329733
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/log/LogDivertAppender.java
##########
@@ -242,12 +244,17 @@ public static void
registerRoutingAppender(org.apache.hadoop.conf.Configuration
LoggerContext context = (LoggerContext) LogManager.getContext(false);
Configuration configuration = context.getConfiguration();
+ PurgePolicy purgePolicy = IdlePurgePolicy.createPurgePolicy("60", null,
"SECONDS", configuration);
Review comment:
IIRC the 60s was configurable from the log4j2.properties earlier. Can we
make this configurable via some means (preferably log4j2 properties)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 607675)
Time Spent: 2h (was: 1h 50m)
> Operation Logging still leaks the log4j Appenders
> -------------------------------------------------
>
> Key: HIVE-24590
> URL: https://issues.apache.org/jira/browse/HIVE-24590
> Project: Hive
> Issue Type: Bug
> Components: Logging
> Reporter: Eugene Chung
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
> Attachments: Screen Shot 2021-01-06 at 18.42.05.png, Screen Shot
> 2021-01-06 at 18.42.24.png, Screen Shot 2021-01-06 at 18.42.55.png, Screen
> Shot 2021-01-06 at 21.38.32.png, Screen Shot 2021-01-06 at 21.47.28.png,
> Screen Shot 2021-01-08 at 21.01.40.png, add_debug_log_and_trace.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> I'm using Hive 3.1.2 with options below.
> * hive.server2.logging.operation.enabled=true
> * hive.server2.logging.operation.level=VERBOSE
> * hive.async.log.enabled=false
> I already know the ticket, https://issues.apache.org/jira/browse/HIVE-17128
> but HS2 still leaks log4j RandomAccessFileManager.
> !Screen Shot 2021-01-06 at 18.42.05.png|width=756,height=197!
> I checked the operation log file which is not closed/deleted properly.
> !Screen Shot 2021-01-06 at 18.42.24.png|width=603,height=272!
> Then there's the log,
> {code:java}
> client.TezClient: Shutting down Tez Session, sessionName= ....{code}
> !Screen Shot 2021-01-06 at 18.42.55.png|width=1372,height=26!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
