[
https://issues.apache.org/jira/browse/HIVE-25195?focusedWorklogId=607878&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607878
]
ASF GitHub Bot logged work on HIVE-25195:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/21 13:49
Start Date: 07/Jun/21 13:49
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2347:
URL: https://github.com/apache/hive/pull/2347#discussion_r646605093
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java
##########
@@ -381,27 +379,23 @@ private void collectCommitInformation(TezWork work)
throws IOException, TezExcep
if (child.isDirectory() &&
child.getPath().getName().contains(jobIdPrefix)) {
// folder name pattern is queryID-jobID, we're removing the
queryID part to get the jobID
String jobIdStr =
child.getPath().getName().substring(jobConf.get("hive.query.id").length() + 1);
- // get all target tables this vertex wrote to
+
List<String> tables = new ArrayList<>();
+ Map<String, String> icebergProperties = new HashMap<>();
for (Map.Entry<String, String> entry : jobConf) {
- if (entry.getKey().startsWith("iceberg.mr.serialized.table."))
{
-
tables.add(entry.getKey().substring("iceberg.mr.serialized.table.".length()));
+ if
(entry.getKey().startsWith(ICEBERG_SERIALIZED_TABLE_PREFIX)) {
+ // get all target tables this vertex wrote to
+
tables.add(entry.getKey().substring(ICEBERG_SERIALIZED_TABLE_PREFIX.length()));
+ } else if (entry.getKey().startsWith("iceberg.mr.")) {
+ // find iceberg props in jobConf as they can be needed, but
not available, during job commit
+ icebergProperties.put(entry.getKey(), entry.getValue());
}
}
- // save information for each target table (jobID, task num,
query state)
- for (String table : tables) {
- sessionConf.set(HIVE_TEZ_COMMIT_JOB_ID_PREFIX + table,
jobIdStr);
- sessionConf.setInt(HIVE_TEZ_COMMIT_TASK_COUNT_PREFIX + table,
- status.getProgress().getSucceededTaskCount());
- }
+ // save information for each target table
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 607878)
Time Spent: 3.5h (was: 3h 20m)
> Store Iceberg write commit and ctas information in QueryState
> --------------------------------------------------------------
>
> Key: HIVE-25195
> URL: https://issues.apache.org/jira/browse/HIVE-25195
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> We should replace the current method of passing Iceberg write commit-related
> information (jobID, task num) and CTAS info via the session conf using
> prefixed keys. We have a new way of doing that more cleanly, using the
> QueryState object. This should make the code easier to maintain and guard
> against accidental session conf pollution.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
