[
https://issues.apache.org/jira/browse/HIVE-25200?focusedWorklogId=608413&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608413
]
ASF GitHub Bot logged work on HIVE-25200:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/21 11:42
Start Date: 08/Jun/21 11:42
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2351:
URL: https://github.com/apache/hive/pull/2351#discussion_r647358340
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -310,6 +337,24 @@ public void
rollbackAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTab
}
}
+ private void setupAlterOperationType(EnvironmentContext context) throws
MetaException {
+ if (context != null) {
+ Map<String, String> contextProperties = context.getProperties();
+ if (contextProperties != null) {
+ String stringOpType =
contextProperties.get(ALTER_TABLE_OPERATION_TYPE);
+ if (stringOpType != null) {
+ currentAlterTableOp = AlterTableType.valueOf(stringOpType);
+ if (SUPPORTED_ALTER_OPS.stream().noneMatch(op ->
op.equals(currentAlterTableOp))) {
+ throw new MetaException(
+ "Unsupported ALTER TABLE operation type for Iceberg tables,
must be: " + allowedAlterTypes.toString());
+ }
+ }
+ return;
+ }
+ }
+ throw new MetaException("ALTER TABLE operation type could not be
determined.");
Review comment:
Can we maybe get rid of the return by putting this exception to the
beginning of the method?
e.g.
```
if (context == null || context.getProperties() == null) {
throw new ...
}
```
The other thing I'm thinking of is that it'd be informative to include the
hmsTable name in the exception message as well (for this and the above too).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 608413)
Time Spent: 5h 10m (was: 5h)
> Alter table add columns support for Iceberg tables
> --------------------------------------------------
>
> Key: HIVE-25200
> URL: https://issues.apache.org/jira/browse/HIVE-25200
> Project: Hive
> Issue Type: Improvement
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Since Iceberg counts as being a non-native Hive table, addColumn operation
> needs to be implemented by the help of Hive meta hooks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
