[
https://issues.apache.org/jira/browse/HIVE-23571?focusedWorklogId=609246&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609246
]
ASF GitHub Bot logged work on HIVE-23571:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/21 16:52
Start Date: 09/Jun/21 16:52
Worklog Time Spent: 10m
Work Description: sankarh commented on a change in pull request #2128:
URL: https://github.com/apache/hive/pull/2128#discussion_r648497223
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
##########
@@ -918,6 +938,29 @@ private void updateAllTableConstraints(RawStore rawStore,
String catName, String
}
}
+ private void updateValidWriteIdList(TxnStore txnStore, String catName,
String dbName, String tblName) {
+ catName = StringUtils.normalizeIdentifier(catName);
+ dbName = StringUtils.normalizeIdentifier(dbName);
+ tblName = StringUtils.normalizeIdentifier(tblName);
+ LOG.debug("CachedStore: updating cached table validWriteIdlist for
catalog: {}, database: {}, table: {}", catName,
+ dbName, tblName);
+ ValidWriteIdList validWriteIdList = null;
+ try {
+ Deadline.startTimer("getValidWriteIds");
+ validWriteIdList =
TxnCommonUtils.createValidReaderWriteIdList(txnStore.getValidWriteIds(
Review comment:
AFAIK, we are targeting strict consistency with "Synchronized metastore
cache" work. Eventual consistency is supported even today with regular refresh
of cache with the interval of 1 min. Pls recheck this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 609246)
Time Spent: 3h 50m (was: 3h 40m)
> [CachedStore] Add ValidWriteIdList to SharedCache.TableWrapper
> --------------------------------------------------------------
>
> Key: HIVE-23571
> URL: https://issues.apache.org/jira/browse/HIVE-23571
> Project: Hive
> Issue Type: Sub-task
> Reporter: Kishen Das
> Assignee: Ashish Sharma
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Add ValidWriteIdList to SharedCache.TableWrapper. This would be used in
> deciding whether a given read request can be served from the cache or we have
> to reload it from the backing database.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
