[
https://issues.apache.org/jira/browse/HIVE-25208?focusedWorklogId=609539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609539
]
ASF GitHub Bot logged work on HIVE-25208:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/21 07:55
Start Date: 10/Jun/21 07:55
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2359:
URL: https://github.com/apache/hive/pull/2359#discussion_r648941044
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java
##########
@@ -263,4 +264,23 @@ default boolean supportsPartitionTransform() {
default String getFileFormatPropertyKey() {
return null;
}
+
+ /**
+ * Check if we should use the {@link #nativeCommit(Properties, boolean)}
method for committing inserts instead of
+ * using file copy in the {@link org.apache.hadoop.hive.ql.exec.MoveTask}-s.
+ * @return
+ */
+ default boolean useNativeCommit() {
+ return false;
+ }
+
+ /**
+ * Commits the inserts for the non-native tables. Used in the {@link
org.apache.hadoop.hive.ql.exec.MoveTask}.
Review comment:
It's a bit strange that we use the term native commit but only for
non-native tables :) But to be honest, I couldn't find a better name yet
either, because `nativeCommit` still kinda makes sense :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 609539)
Time Spent: 1h 10m (was: 1h)
> Refactor Iceberg commit to the MoveTask/MoveWork
> ------------------------------------------------
>
> Key: HIVE-25208
> URL: https://issues.apache.org/jira/browse/HIVE-25208
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Instead of committing Iceberg changes in `DefaultMetaHook.preCommitInsert` we
> should commit in MoveWork so we are using the same flow as normal tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
