[
https://issues.apache.org/jira/browse/HIVE-25225?focusedWorklogId=609543&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609543
]
ASF GitHub Bot logged work on HIVE-25225:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/21 07:59
Start Date: 10/Jun/21 07:59
Worklog Time Spent: 10m
Work Description: maheshk114 commented on a change in pull request #2376:
URL: https://github.com/apache/hive/pull/2376#discussion_r648942867
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -7006,16 +7006,40 @@ private boolean updatePartitonColStatsInternal(Table
tbl, ColumnStatistics colSt
+ " part=" + csd.getPartName());
boolean ret = false;
+
+ Map<String, String> parameters;
+ List<String> partVals;
+ boolean committed = false;
+ getMS().openTransaction();
+
try {
if (tbl == null) {
tbl = getTable(catName, dbName, tableName);
}
- ret = updatePartitionColStatsInBatch(tbl,
Collections.singletonMap(csd.getPartName(), colStats),
- validWriteIds, writeId);
+ partVals = getPartValsFromName(tbl, csd.getPartName());
+ parameters = getMS().updatePartitionColumnStatistics(colStats, partVals,
validWriteIds, writeId);
+ if (parameters != null) {
+ if (transactionalListeners != null &&
!transactionalListeners.isEmpty()) {
+ MetaStoreListenerNotifier.notifyEvent(transactionalListeners,
+ EventType.UPDATE_PARTITION_COLUMN_STAT,
+ new UpdatePartitionColumnStatEvent(colStats, partVals,
parameters, tbl,
+ writeId, this));
+ }
+ if (!listeners.isEmpty()) {
Review comment:
This is the old code so i have kept it as it is. Other methods are also
using it same way.
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -9037,8 +9061,16 @@ public boolean
set_aggr_stats_for(SetPartitionsStatsRequest request) throws TExc
} else { // No merge.
Table t = getTable(catName, dbName, tableName);
// We don't short-circuit on errors here anymore. That can leave acid
stats invalid.
- ret = updatePartitionColStatsInBatch(t, newStatsMap,
- request.getValidWriteIdList(), request.getWriteId());
+ if (MetastoreConf.getBoolVar(getConf(), ConfVars.TRY_DIRECT_SQL)) {
Review comment:
I think for get operations it's fine. But for set operations we have to
start a transaction in HMS handler and for direct sql flow that may cause issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 609543)
Time Spent: 50m (was: 40m)
> Update column stat throws NPE if direct sql is disabled
> -------------------------------------------------------
>
> Key: HIVE-25225
> URL: https://issues.apache.org/jira/browse/HIVE-25225
> Project: Hive
> Issue Type: Sub-task
> Reporter: mahesh kumar behera
> Assignee: mahesh kumar behera
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In case direct sql is disabled, the MetaStoreDirectSql object is not
> initialised and thats causing NPE.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
