[
https://issues.apache.org/jira/browse/HIVE-25140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361327#comment-17361327
]
Matt McCline commented on HIVE-25140:
-------------------------------------
[~kgyrtkirk] I have thought about this. I think using something like aspect
oriented approach would make the Distributed Tracing (DT) feature much weaker
since to add Spans you have to learn a new tool and DT could be out of sight
and probably get neglected. The pattern of code used to create Spans is well
established. OpenTelemetry (OTL) and its predecessors OpenTracing and
OpenCensus use this pattern. You see the pattern in the DT books and in
numerous tutorials on the web. And a bunch of programming languages are
supported by OTL.
Also I do not think it adds a lot of code. It does sprinkle changes across the
code base yes. The very nature of manually instrumenting code like Hive to do
tracing is to start at the top of execution (e.g. BeeLine's SQL Statement) and
judicially look for large areas of execution that would provide us benefit from
a Span. The decision process for adding a new Span becomes a design process. I
think it will be good for people to encounter Span creation in the code and
explore what it does. It is easy with IDE autocomplete to add a new Span and go
see how it looks in the UI.
> Hive Distributed Tracing -- Part 1: Disabled
> --------------------------------------------
>
> Key: HIVE-25140
> URL: https://issues.apache.org/jira/browse/HIVE-25140
> Project: Hive
> Issue Type: Sub-task
> Reporter: Matt McCline
> Assignee: Matt McCline
> Priority: Major
> Attachments: HIVE-25140.01.patch, HIVE-25140.02.patch,
> HIVE-25140.03.patch
>
>
> Infrastructure except exporters to Jaeger or OpenTelementry (OTL) due to
> Thrift and protobuf version conflicts. A logging only exporter is used.
> There are Spans for BeeLine and Hive. Server 2. The code was developed on
> branch-3.1 and porting Spans to the Hive MetaStore on master is taking more
> time due to major metastore code refactoring.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
