[
https://issues.apache.org/jira/browse/HIVE-25207?focusedWorklogId=610621&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-610621
]
ASF GitHub Bot logged work on HIVE-25207:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/21 10:35
Start Date: 14/Jun/21 10:35
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #2356:
URL: https://github.com/apache/hive/pull/2356#discussion_r650833522
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadWorkMBean.java
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.exec.repl;
+
+public interface ReplLoadWorkMBean {
Review comment:
Done
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplStatsTracker.java
##########
@@ -29,6 +32,7 @@
* Tracks the replication statistics per event type.
*/
public class ReplStatsTracker {
+ private static final Logger LOG =
LoggerFactory.getLogger(ReplStatsTracker.class);
Review comment:
Removed
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
##########
@@ -4663,6 +4678,26 @@ public void testIncrementalStatisticsMetrics() throws
Throwable {
}
}
}
+ verifyMBeanStatistics(testName, replDbName, nameStri, events);
+ // Clean up the test setup.
+ ReplLoadWork.setMbeansParamsForTesting(false,false);
+ MBeans.unregister(ObjectName.getInstance(nameStri));
+ }
+
+ private void verifyMBeanStatistics(String testName, String replDbName,
String nameStri, String[] events)
+ throws MalformedObjectNameException, MBeanException,
AttributeNotFoundException, InstanceNotFoundException,
+ ReflectionException {
+ ObjectName name = ObjectName.getInstance(nameStri);
+
+ assertTrue(
+ ManagementFactory.getPlatformMBeanServer().getAttribute(name,
"Stage").toString().contains("INCREMENTAL"));
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 610621)
Time Spent: 0.5h (was: 20m)
> Expose incremental load statistics via JMX
> ------------------------------------------
>
> Key: HIVE-25207
> URL: https://issues.apache.org/jira/browse/HIVE-25207
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Expose the incremental load details and statistics at per policy level in the
> JMX.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
