[
https://issues.apache.org/jira/browse/HIVE-25268?focusedWorklogId=612351&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-612351
]
ASF GitHub Bot logged work on HIVE-25268:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/21 04:56
Start Date: 20/Jun/21 04:56
Worklog Time Spent: 10m
Work Description: ashish-kumar-sharma commented on a change in pull
request #2409:
URL: https://github.com/apache/hive/pull/2409#discussion_r654876476
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateFormat.java
##########
@@ -85,21 +87,31 @@ public ObjectInspector initialize(ObjectInspector[]
arguments) throws UDFArgumen
String fmtStr = getConstantStringValue(arguments, 1);
if (fmtStr != null) {
try {
- formatter = new SimpleDateFormat(fmtStr);
-
formatter.setCalendar(DateTimeMath.getTimeZonedProlepticGregorianCalendar());
+ if (timeZone == null) {
+ timeZone = SessionState.get() == null ? new
HiveConf().getLocalTimeZone() : SessionState.get().getConf()
+ .getLocalTimeZone();
+ }
+ formatter = DateTimeFormatter.ofPattern(fmtStr).withZone(timeZone);
} catch (IllegalArgumentException e) {
// ignore
}
}
} else {
- throw new UDFArgumentTypeException(1, getFuncName() + " only takes
constant as "
- + getArgOrder(1) + " argument");
+ throw new UDFArgumentTypeException(1, getFuncName() + " only takes
constant as " + getArgOrder(1) + " argument");
}
ObjectInspector outputOI =
PrimitiveObjectInspectorFactory.writableStringObjectInspector;
return outputOI;
}
+ @Override
Review comment:
This method is not required. Because idea is to first check the session
for config "hive.local.time.zone" and then fall back to cluster default.
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDateFormat.java
##########
@@ -176,7 +176,6 @@ public void testWrongFmt() throws HiveException {
Review comment:
Add test for date older then 1900 with timestamp.
##########
File path: ql/src/test/queries/clientpositive/udf_date_format.q
##########
@@ -78,3 +78,8 @@ select date_format("2015-04-08 10:30:45","yyyy-MM-dd
HH:mm:ss.SSS z");
--julian date
set hive.local.time.zone=UTC;
select date_format("1001-01-05","dd---MM--yyyy");
+
+--dates prior to 1900 in another time zone
+set hive.local.time.zone=Asia/Bangkok;
Review comment:
Add multiple query with different time zone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 612351)
Time Spent: 1h 20m (was: 1h 10m)
> date_format udf doesn't work for dates prior to 1900 if the timezone is
> different from UTC
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-25268
> URL: https://issues.apache.org/jira/browse/HIVE-25268
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Affects Versions: 3.1.0, 3.1.1, 3.1.2, 4.0.0
> Reporter: Nikhil Gupta
> Assignee: Nikhil Gupta
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> *Hive 1.2.1*:
> {code:java}
> select date_format('1400-01-14 01:00:00', 'yyyy-MM-dd HH:mm:ss z');
> +--------------------------+--+
> | _c0 |
> +--------------------------+--+
> | 1400-01-14 01:00:00 ICT |
> +--------------------------+--+
> select date_format('1800-01-14 01:00:00', 'yyyy-MM-dd HH:mm:ss z');
> +--------------------------+--+
> | _c0 |
> +--------------------------+--+
> | 1800-01-14 01:00:00 ICT |
> +--------------------------+--+
> {code}
> *Hive 3.1, Hive 4.0:*
> {code:java}
> select date_format('1400-01-14 01:00:00', 'yyyy-MM-dd HH:mm:ss z');
> +--------------------------+
> | _c0 |
> +--------------------------+
> | 1400-01-06 01:17:56 ICT |
> +--------------------------+
> select date_format('1800-01-14 01:00:00', 'yyyy-MM-dd HH:mm:ss z');
> +--------------------------+
> | _c0 |
> +--------------------------+
> | 1800-01-14 01:17:56 ICT |
> +--------------------------+
> {code}
> VM timezone is set to 'Asia/Bangkok'
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
