[
https://issues.apache.org/jira/browse/HIVE-25272?focusedWorklogId=613123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-613123
]
ASF GitHub Bot logged work on HIVE-25272:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/21 07:50
Start Date: 22/Jun/21 07:50
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r655840289
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -74,7 +74,7 @@
/**
* TestReplicationScenariosAcidTables - test replication for ACID tables.
*/
[email protected]("HIVE-25267")
+//@org.junit.Ignore("HIVE-25267")
Review comment:
Thanks for the review @pvary . No, it doesn't. I wanted to get a
feedback on this. Also, the current test were in this file only so had enabled
it. I will revert this if I couldn't fix the flakiness as a part of JIRA
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,28 @@ public void
testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testREADOperationsNotCapturedInNotificationLog() throws
Throwable {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 613123)
Time Spent: 1.5h (was: 1h 20m)
> READ transactions are getting logged in NOTIFICATION LOG
> --------------------------------------------------------
>
> Key: HIVE-25272
> URL: https://issues.apache.org/jira/browse/HIVE-25272
> Project: Hive
> Issue Type: Bug
> Reporter: Pravin Sinha
> Assignee: Pravin Sinha
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> While READ transactions are already skipped from getting logged in
> NOTIFICATION logs, few are still getting logged. Need to skip those
> transactions as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
