[
https://issues.apache.org/jira/browse/HIVE-25190?focusedWorklogId=613499&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-613499
]
ASF GitHub Bot logged work on HIVE-25190:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/21 14:02
Start Date: 22/Jun/21 14:02
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #2408:
URL: https://github.com/apache/hive/pull/2408#discussion_r656253168
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java
##########
@@ -49,13 +49,14 @@
*/
public int[] length;
- // A call to increaseBufferSpace() or ensureValPreallocated() will ensure
that buffer[] points to
- // a byte[] with sufficient space for the specified size.
- private byte[] buffer; // optional buffer to use when actually copying in
data
+ // Calls to ensureValPreallocated() ensure that buffer starting at nextFree
+ // points to a byte[] with sufficient space for the specified size.
Review comment:
I find the use of smallBuffer and buffer rather confusing after
refactoring.
Would it make sense to rename to something more descriprive like currBuffer
and next Buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 613499)
Time Spent: 20m (was: 10m)
> BytesColumnVector fails when the aggregate size is > 1gb
> --------------------------------------------------------
>
> Key: HIVE-25190
> URL: https://issues.apache.org/jira/browse/HIVE-25190
> Project: Hive
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, BytesColumnVector will allocate a buffer for small values (< 1mb),
> but fail with:
> {code:java}
> new RuntimeException("Overflow of newLength. smallBuffer.length="
> + smallBuffer.length + ", nextElemLength=" + nextElemLength);
> {code:java}
> if the aggregate size of the buffer crosses over 1gb.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
