[ https://issues.apache.org/jira/browse/HIVE-25253?focusedWorklogId=614404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614404 ]
ASF GitHub Bot logged work on HIVE-25253: ----------------------------------------- Author: ASF GitHub Bot Created on: 24/Jun/21 09:23 Start Date: 24/Jun/21 09:23 Worklog Time Spent: 10m Work Description: kasakrisz commented on a change in pull request #2401: URL: https://github.com/apache/hive/pull/2401#discussion_r657780988 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java ########## @@ -1252,4 +1252,18 @@ public static ImmutableBitSet extractRefs(Aggregate aggregate) { } return refs.build(); } + + public static Set<RexTableInputRef> findRexTableInputRefs(RexNode rexNode) { Review comment: `RexUtil.gatherTableReferences` returns `Set<RelTableRef>` and not Set<RexTableInputRef>. `RelTableRef` does not contains the index of this InputRef in the TS schema which is required to identify if the `RexTableInputRef` instance refers a partition column or not. `RelOptHiveTable.getPartColInfoMap()` contains the indexes not the instances. The RexTableInputRef index is also required by `HiveCardinalityPreservingJoinOptimization` that is why I extarcted `findRexTableInputRefs`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 614404) Time Spent: 1h (was: 50m) > Incremental rebuild of partitioned insert only materialized views > ----------------------------------------------------------------- > > Key: HIVE-25253 > URL: https://issues.apache.org/jira/browse/HIVE-25253 > Project: Hive > Issue Type: Improvement > Components: CBO, Materialized views > Reporter: Krisztian Kasa > Assignee: Krisztian Kasa > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)