[
https://issues.apache.org/jira/browse/HIVE-25287?focusedWorklogId=614965&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614965
]
ASF GitHub Bot logged work on HIVE-25287:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/21 12:32
Start Date: 25/Jun/21 12:32
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2428:
URL: https://github.com/apache/hive/pull/2428#discussion_r658727472
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -288,7 +288,7 @@ public void
commitAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
break;
case ADDPROPS:
case DROPPROPS:
- alterTableProperties(hmsTable, context.getProperties());
+ alterTableProperties(hmsTable, contextProperties);
Review comment:
Do we need this `contextProperties` variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 614965)
Time Spent: 20m (was: 10m)
> NPE on insertions into Iceberg-backed tables
> --------------------------------------------
>
> Key: HIVE-25287
> URL: https://issues.apache.org/jira/browse/HIVE-25287
> Project: Hive
> Issue Type: Bug
> Components: File Formats
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> NPE is thrown upon inserting values into an Iceberg table, as statistics
> generation triggers an alter table operation with undefined (alter)operation
> type:
> {code:java}
> INFO : Executing stats task
> INFO : [Warning] could not update stats.Failed with exception null
> java.lang.NullPointerException
> at
> org.apache.iceberg.mr.hive.HiveIcebergMetaHook.commitAlterTable(HiveIcebergMetaHook.java:283)
> at
> org.apache.hadoop.hive.metastore.HiveMetaStoreClient.alter_table(HiveMetaStoreClient.java:572)
> at
> org.apache.hadoop.hive.ql.metadata.SessionHiveMetaStoreClient.alter_table(SessionHiveMetaStoreClient.java:500)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.hadoop.hive.metastore.RetryingMetaStoreClient.invoke(RetryingMetaStoreClient.java:218)
> at com.sun.proxy.$Proxy124.alter_table(Unknown Source)
> at org.apache.hadoop.hive.ql.metadata.Hive.alterTable(Hive.java:854)
> at org.apache.hadoop.hive.ql.metadata.Hive.alterTable(Hive.java:806)
> at org.apache.hadoop.hive.ql.metadata.Hive.alterTable(Hive.java:786)
> at
> org.apache.hadoop.hive.ql.stats.BasicStatsTask.aggregateStats(BasicStatsTask.java:279)
> at
> org.apache.hadoop.hive.ql.stats.BasicStatsTask.process(BasicStatsTask.java:100)
> at
> org.apache.hadoop.hive.ql.exec.StatsTask.execute(StatsTask.java:107)
> at org.apache.hadoop.hive.ql.exec.Task.executeTask(Task.java:212)
> at
> org.apache.hadoop.hive.ql.exec.TaskRunner.runSequential(TaskRunner.java:105)
> at org.apache.hadoop.hive.ql.Executor.launchTask(Executor.java:361)
> at org.apache.hadoop.hive.ql.Executor.launchTasks(Executor.java:334)
> at org.apache.hadoop.hive.ql.Executor.runTasks(Executor.java:245)
> at org.apache.hadoop.hive.ql.Executor.execute(Executor.java:108)
> at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:348)
> at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:204)
> at org.apache.hadoop.hive.ql.Driver.run(Driver.java:153)
> at org.apache.hadoop.hive.ql.Driver.run(Driver.java:148)
> at
> org.apache.hadoop.hive.ql.reexec.ReExecDriver.run(ReExecDriver.java:164)
> at
> org.apache.hive.service.cli.operation.SQLOperation.runQuery(SQLOperation.java:234)
> at
> org.apache.hive.service.cli.operation.SQLOperation.access$500(SQLOperation.java:89)
> at
> org.apache.hive.service.cli.operation.SQLOperation$BackgroundWork$1.run(SQLOperation.java:337)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1682)
> at
> org.apache.hive.service.cli.operation.SQLOperation$BackgroundWork.run(SQLOperation.java:357)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
