[
https://issues.apache.org/jira/browse/HIVE-25314?focusedWorklogId=621604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621604
]
ASF GitHub Bot logged work on HIVE-25314:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/21 19:57
Start Date: 12/Jul/21 19:57
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2458:
URL: https://github.com/apache/hive/pull/2458#discussion_r667818010
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
Do we know what happens when we use the "old" partition syntax for
identity transforms?
`CREATE TABLE tbl (a int, b int) STORED BY ICEBERG PARTITIONED BY (c string)`
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
sorry, I probably wasn't clear, I meant to ask about the `PARTITIONED BY
(c string)` syntax (which creates a single, identity transform partition). But
also testing the json property is a good call too.
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
Great!
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
Although...on second thought that won't produce a syntactically correct
statement right? because we'd need to `c string` to be in the column
definitions then like this:
```
CREATE TABLE tbl (a int, b int, c string) PARTITIONED BY SPEC(c) STORED BY
ICEBERG
```
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
Great :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 621604)
Time Spent: 1.5h (was: 1h 20m)
> Implement SHOW CREATE TABLE command for Iceberg tables
> ------------------------------------------------------
>
> Key: HIVE-25314
> URL: https://issues.apache.org/jira/browse/HIVE-25314
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Implement SHOW CREATE TABLE, including the partitioning info as well in the
> output (even though the HMS table is unpartitioned). That would probably
> require loading the Iceberg table to acquire the partitioning information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
