[
https://issues.apache.org/jira/browse/HIVE-25294?focusedWorklogId=623364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623364
]
ASF GitHub Bot logged work on HIVE-25294:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/21 02:28
Start Date: 16/Jul/21 02:28
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #2435:
URL: https://github.com/apache/hive/pull/2435#discussion_r670920872
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -374,9 +362,14 @@ public HMSHandler(String name, Configuration conf, boolean
init) throws MetaExce
}
}
}
- if (init) {
- init();
- }
+ }
+
+ @VisibleForTesting
+ public static HMSHandler getInitializedHandler(String name, Configuration
conf)
Review comment:
The `init` is set to true only in our tests, the
[RetryingHMSHandler](https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java#L80)
will init the HMSHandler, and HiveMetaStore(including the local mode) uses
RetryingHMSHandler to delegate the request to the initialized HMSHandler, so I
propose to remove the boolean trick in the constructors, introduces a new
method `getInitializedHandler` mainly for the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 623364)
Time Spent: 1.5h (was: 1h 20m)
> Optimise the metadata count queries for local mode
> --------------------------------------------------
>
> Key: HIVE-25294
> URL: https://issues.apache.org/jira/browse/HIVE-25294
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When Metastore is in local mode, the client uses his own private HMSHandler
> to get the meta data, the HMSHandler should be initialized before being
> ready to serve. When the metrics is enabled, HMSHandler will count the number
> of db, table, partitions, which cloud lead to some problems.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
