[
https://issues.apache.org/jira/browse/HIVE-24918?focusedWorklogId=624206&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-624206
]
ASF GitHub Bot logged work on HIVE-24918:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/21 07:56
Start Date: 19/Jul/21 07:56
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2121:
URL: https://github.com/apache/hive/pull/2121#discussion_r672070763
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpWork.java
##########
@@ -119,16 +122,47 @@ int maxEventLimit() throws Exception {
return maxEventLimit;
}
+ public boolean isFirstDumpAfterFailover() {
+ return firstDumpAfterFailover;
+ }
+
+ public void setFirstDumpAfterFailover(boolean firstDumpAfterFailover) {
+ this.firstDumpAfterFailover = firstDumpAfterFailover;
+ }
+
+ FailoverMetaData getFailoverMetadata() {
+ return fmd;
+ }
+
+ void setFailoverMetadata(FailoverMetaData fmd) {
+ this.fmd = fmd;
+ }
+
+ public boolean isFailoverInProgress() {
+ return failoverInProgress;
+ }
+
+ public void setFailoverInProgress(boolean failoverInProgress) {
+ this.failoverInProgress = failoverInProgress;
+ }
+
void setEventFrom(long eventId) {
eventFrom = eventId;
}
// Override any user specification that changes the last event to be dumped.
- void overrideLastEventToDump(Hive fromDb, long bootstrapLastId) throws
Exception {
+ void overrideLastEventToDump(Hive fromDb, long bootstrapLastId, long
failoverEventId) throws Exception {
// If we are bootstrapping ACID tables, we need to dump all the events
upto the event id at
// the beginning of the bootstrap dump and also not dump any event after
that. So we override
// both, the last event as well as any user specified limit on the number
of events. See
// bootstrampDump() for more details.
+ if (failoverInProgress) {
+ assert failoverEventId > 0;
+ eventTo = failoverEventId;
+ LoggerFactory.getLogger(this.getClass())
Review comment:
Move to INFO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 624206)
Time Spent: 4.5h (was: 4h 20m)
> Handle failover case during Repl Dump
> -------------------------------------
>
> Key: HIVE-24918
> URL: https://issues.apache.org/jira/browse/HIVE-24918
> Project: Hive
> Issue Type: New Feature
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> To handle:
> a) Whenever user wants to go ahead with failover, during the next or
> subsequent repl dump operation upon confirming that there are no pending open
> transaction events, It should create a _failover_ready marker file in the
> dump dir. This marker file would contain scheduled query name
> that has generated this dump.
> b) Skip next repl dump instances once we have the marker file placed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
