[
https://issues.apache.org/jira/browse/HIVE-25281?focusedWorklogId=625763&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-625763
]
ASF GitHub Bot logged work on HIVE-25281:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jul/21 19:25
Start Date: 20/Jul/21 19:25
Worklog Time Spent: 10m
Work Description: kishendas commented on a change in pull request #2425:
URL: https://github.com/apache/hive/pull/2425#discussion_r673413945
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -610,6 +637,8 @@ struct Partition {
10: optional i64 writeId=-1,
11: optional bool isStatsCompliant,
12: optional ColumnStatistics colStats // column statistics for partition
Review comment:
Comma is missing after colStats. Does this still work fine, when you
generate the code ?
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -610,6 +637,8 @@ struct Partition {
10: optional i64 writeId=-1,
11: optional bool isStatsCompliant,
12: optional ColumnStatistics colStats // column statistics for partition
+ 13: optional FileMetadata fileMetadata // optional serialized file-metadata
useful
+ // for certain execution engines
Review comment:
Please align the comment
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -595,6 +619,9 @@ struct Table {
24: optional list<string> requiredWriteCapabilities
25: optional i64 id, // id of the table. It will be ignored
if set. It's only for
// read purposed
+ 26: optional FileMetadata fileMetadata // optional serialized file-metadata
for this table
+ // for certain execution engines
Review comment:
You want to align this comment with previous line, so that its easy to
read ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 625763)
Time Spent: 20m (was: 10m)
> Add optional fields to enable returning filemetadata for tables and partitions
> ------------------------------------------------------------------------------
>
> Key: HIVE-25281
> URL: https://issues.apache.org/jira/browse/HIVE-25281
> Project: Hive
> Issue Type: Improvement
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The hive_metastore.thrift interface defines the fields for Table and
> Partition objects. Certain SQL engines like Impala use Table and Partition
> from the HMS and then augment it to include additional metadata useful for
> the engine itself e.g file metadata. It would be good to add support for such
> fields in the thrift definition itself. These fields currently will be
> optional fields so that HMS itself doesn't really need to support it for now,
> but this can be supported in future depending on which SQL engine is talking
> to HMS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
