[ 
https://issues.apache.org/jira/browse/HIVE-25306?focusedWorklogId=626220&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626220
 ]

ASF GitHub Bot logged work on HIVE-25306:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Jul/21 16:25
            Start Date: 21/Jul/21 16:25
    Worklog Time Spent: 10m 
      Work Description: ashish-kumar-sharma commented on a change in pull 
request #2445:
URL: https://github.com/apache/hive/pull/2445#discussion_r674145304



##########
File path: 
ql/src/test/results/clientpositive/llap/probedecode_mapjoin_stats.q.out
##########
@@ -416,4 +416,4 @@ POSTHOOK: Input: default@orders_fact
 POSTHOOK: Input: default@seller_dim
 #### A masked pattern was here ####
 101    101     12345   12345   Seller 1        Item 101        2001-01-30 
00:00:00
-104    104     23456   23456   Seller 2        Item 104        2002-03-02 
00:00:00
+104    104     23456   23456   Seller 2        Item 104        NULL

Review comment:
       Because of the following query in probedecode_mapjoin_stats.q
   
   INSERT INTO orders_fact values(23456, 104, '2002-02-30 00:00:00'); 
   
   Also timestamp format is "YYYY-MM-DD HH:MM:SS" due to that '2002-02-30 
00:00:00' value get converted to null. Since probedecode_mapjoin_stats.q is to 
test happy flow of mapjoin_stats so lets make it some valid date to avoid 
confusion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 626220)
    Time Spent: 2h 20m  (was: 2h 10m)

> Move Date and Timestamp parsing from ResolverStyle.LENIENT to 
> ResolverStyle.STRICT
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-25306
>                 URL: https://issues.apache.org/jira/browse/HIVE-25306
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Planning, UDF
>            Reporter: Ashish Sharma
>            Assignee: Ashish Sharma
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: DB_compare.JPG
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Description - 
> Currently Date.java and Timestamp.java use DateTimeFormatter for parsing to 
> convert the date/timpstamp from int,string,char etc to Date or Timestamp. 
> Default DateTimeFormatter which use ResolverStyle.LENIENT which mean date 
> like "1992-13-12" is converted to "2000-01-12", 
> Moving DateTimeFormatter which use ResolverStyle.STRICT which mean date like 
> "1992-13-12" is not be converted instead NULL is return.
> https://docs.google.com/document/d/1YTTPlNq3qyzlKfYVkSl3EFhVQ6-wa9WFRdkdIeCoc1Y/edit?usp=sharing
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to