[
https://issues.apache.org/jira/browse/HIVE-25158?focusedWorklogId=626676&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626676
]
ASF GitHub Bot logged work on HIVE-25158:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/21 14:01
Start Date: 22/Jul/21 14:01
Worklog Time Spent: 10m
Work Description: abstractdog commented on a change in pull request #2319:
URL: https://github.com/apache/hive/pull/2319#discussion_r674823717
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -353,7 +353,11 @@ protected HiveConnection(String uri, Properties info,
}
if (isEmbeddedMode) {
client = EmbeddedCLIServicePortal.get(connParams.getHiveConfs());
+ String sessionId =
connParams.getHiveConfs().get(HiveConf.ConfVars.HIVESESSIONID.varname);
Review comment:
this part seems to be hacky, original code made a client from the confs
then cleared the conf, now we're forcing the sessionId to be present in the
hive confs after clearing, why is it?
this way we'll have an almost empty connParams.getHiveConfs(), having only
session id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 626676)
Time Spent: 40m (was: 0.5h)
> Beeline/hive command can't get operation logs when hive.session.id is set
> -------------------------------------------------------------------------
>
> Key: HIVE-25158
> URL: https://issues.apache.org/jira/browse/HIVE-25158
> Project: Hive
> Issue Type: Bug
> Reporter: Robbie Zhang
> Assignee: Robbie Zhang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Usually, we can see the operation logs when we run a query from beeline/hive.
> For example, the query ID, the time taken in compiling/executing, the
> application information, etc. But if we use "–hiveconf hive.session.id=xxxx"
> to set the session ID, we can't see the operation logs any more. Here are
> examples:
> * Without hive.session.id
> {code:java}
> $ hive -e "select 1"
> SLF4J: Class path contains multiple SLF4J bindings.
> ...
> Connected to: Apache Hive (version 3.1.3000.7.1.6.0-297)
> Driver: Hive JDBC (version 3.1.3000.7.1.6.0-297)
> Transaction isolation: TRANSACTION_REPEATABLE_READ
> INFO : Compiling
> command(queryId=hive_20210524105207_9d0774b2-8108-4800-a5e4-3b950ae03198):
> select 1
> INFO : Semantic Analysis Completed (retrial = false)
> INFO : Created Hive schema: Schema(fieldSchemas:[FieldSchema(name:_c0,
> type:int, comment:null)], properties:null)
> INFO : Completed compiling
> command(queryId=hive_20210524105207_9d0774b2-8108-4800-a5e4-3b950ae03198);
> Time taken: 0.122 seconds
> INFO : Executing
> command(queryId=hive_20210524105207_9d0774b2-8108-4800-a5e4-3b950ae03198):
> select 1
> INFO : Completed executing
> command(queryId=hive_20210524105207_9d0774b2-8108-4800-a5e4-3b950ae03198);
> Time taken: 0.016 seconds
> INFO : OK
> +------+
> | _c0 |
> +------+
> | 1 |
> +------+
> 1 row selected (0.318 seconds)
> Beeline version 3.1.3000.7.1.6.0-297 by Apache Hive
> {code}
> * With hive.session.id
> {code:java}
> $ hive --hiveconf hive.session.id=abcd -e "select 1"
> SLF4J: Class path contains multiple SLF4J bindings.
> ...
> Connected to: Apache Hive (version 3.1.3000.7.1.6.0-297)
> Driver: Hive JDBC (version 3.1.3000.7.1.6.0-297)
> Transaction isolation: TRANSACTION_REPEATABLE_READ
> +------+
> | _c0 |
> +------+
> | 1 |
> +------+
> 1 row selected (5.862 seconds)
> Beeline version 3.1.3000.7.1.6.0-297 by Apache Hive
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)