[
https://issues.apache.org/jira/browse/HIVE-25143?focusedWorklogId=627093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627093
]
ASF GitHub Bot logged work on HIVE-25143:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/21 10:06
Start Date: 23/Jul/21 10:06
Worklog Time Spent: 10m
Work Description: pgaref commented on pull request #2301:
URL: https://github.com/apache/hive/pull/2301#issuecomment-885534981
Looks like this PR was approved but was never merged.
@belugabehr @miklosgergely shall we reopen this? Whats the plan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 627093)
Time Spent: 0.5h (was: 20m)
> Improve ERROR Logging in QL Package
> -----------------------------------
>
> Key: HIVE-25143
> URL: https://issues.apache.org/jira/browse/HIVE-25143
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I went through and reviewed all of the ERROR logging in the HS2 {{ql}} module
> and I removed (most of) the following bad habits:
>
> * Log-and-Throw (log or throw, not both)
> * Pass in the Exception to the logging framework instead of logging its
> toString() : LOG.error("alter table update columns: {}", e);
> * Add additional context instead of copying the message from the wrapped
> Exception : throw new SemanticException(e.getMessage(), e);
> * The wrapped exception is being lost in some case, though the message
> survives : throw new HiveException(e.getMessage());
> * Remove new-lines from Exception messages, this is annoying as log messages
> should all be on a single line for GREP
> * Not logging the Exception stack trace : LOG.error("Error in close loader:
> " + ie);
> * Logging information but not passing it into an Exception for bubbling up:
> LOG.error("Failed to return session: {} to pool", session, e); throw e;
> * Other miscellaneous improvements
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
