[
https://issues.apache.org/jira/browse/HIVE-25376?focusedWorklogId=627386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627386
]
ASF GitHub Bot logged work on HIVE-25376:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/21 08:38
Start Date: 24/Jul/21 08:38
Worklog Time Spent: 10m
Work Description: szlta commented on a change in pull request #2523:
URL: https://github.com/apache/hive/pull/2523#discussion_r675969829
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/vector/HiveVectorizedReader.java
##########
@@ -60,7 +61,8 @@ private HiveVectorizedReader() {
public static <D> CloseableIterable<D> reader(InputFile inputFile,
FileScanTask task, Map<Integer, ?> idToConstant,
TaskAttemptContext context) {
- JobConf job = (JobConf) context.getConfiguration();
+ // Tweaks on jobConf here are relevant for this task only, so we need to
copy it first as context's conf is reused..
Review comment:
Hm what I meant is that any changes we make to the jobConf instance in
the code below, should not affect anyone else. And for that reason I need to
take a copy of it and do the adjustments on the copied instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 627386)
Time Spent: 0.5h (was: 20m)
> Iceberg vectorized ORC reads fail on reordered partition columns
> ----------------------------------------------------------------
>
> Key: HIVE-25376
> URL: https://issues.apache.org/jira/browse/HIVE-25376
> Project: Hive
> Issue Type: Bug
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Similarly to HIVE-25360 reordering partition columns can cause a problem,
> this time when constant value filling happens for partition columns. Column
> indices must be mapped to the current schema (which may contain the columns
> reordered)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
