[
https://issues.apache.org/jira/browse/HIVE-24946?focusedWorklogId=628212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628212
]
ASF GitHub Bot logged work on HIVE-24946:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/21 07:38
Start Date: 27/Jul/21 07:38
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2529:
URL: https://github.com/apache/hive/pull/2529#discussion_r677196856
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -554,6 +554,24 @@ public void run() throws SemanticException {
}
}
});
+ if (work.shouldFailover()) {
+ listOfPreAckTasks.add(new PreAckTask() {
+ @Override
+ public void run() throws SemanticException {
+ try {
+ Database db = getHive().getDatabase(work.getTargetDatabase());
+ if (!MetaStoreUtils.isTargetOfReplication(db)) {
+ return;
+ }
+ LOG.info("Removing property: {} from database: {}",
ReplConst.TARGET_OF_REPLICATION, db.getName());
+ db.getParameters().remove(ReplConst.TARGET_OF_REPLICATION);
Review comment:
If you remove the property TARGET_OF_REPLICATION at this point of time
which will allow the background threads like Partition Management/ Stat
Updater etc. Can we still rollback in that case? Wondering if we should delay
the removal of this property until first dump in reverse direction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 628212)
Time Spent: 20m (was: 10m)
> Handle failover case during Repl Load
> -------------------------------------
>
> Key: HIVE-24946
> URL: https://issues.apache.org/jira/browse/HIVE-24946
> Project: Hive
> Issue Type: New Feature
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> * Update metric during load to capture the readiness for failover
> * Remove repl.target.for property on target cluster
> * Prepare the dump directory to be used during failover first dump operation
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
