[ 
https://issues.apache.org/jira/browse/HIVE-25390?focusedWorklogId=628213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628213
 ]

ASF GitHub Bot logged work on HIVE-25390:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jul/21 07:38
            Start Date: 27/Jul/21 07:38
    Worklog Time Spent: 10m 
      Work Description: klcopp opened a new pull request #2534:
URL: https://github.com/apache/hive/pull/2534


   ### What changes were proposed in this pull request?
   See HIVE-25390
   
   
   ### Why are the changes needed?
   See HIVE-25390
   
   ### Does this PR introduce _any_ user-facing change?
   Removes metrics compaction_failed_initiator_ratio and 
compaction_failed_cleaner_ratio
   
   ### How was this patch tested?
   Changed unit tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 628213)
    Remaining Estimate: 0h
            Time Spent: 10m

> Metrics compaction_failed_initiator_ratio and compaction_failed_cleaner_ratio 
> should be counters
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-25390
>                 URL: https://issues.apache.org/jira/browse/HIVE-25390
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Karen Coppage
>            Assignee: Karen Coppage
>            Priority: Major
>              Labels: backward-incompatible
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Metric compaction_failed_initiator_ratio represents the ratio of initiator 
> failures to the total number of initiator runs, both computed since Metastore 
> was restarted, represented by a double. This isn't really useable. It would 
> be better if it counted the number of initiator failures since Metastore was 
> restarted so other components can keep an eye on things like "number of 
> initiator failures in the last day".
> Same goes for compaction_failed_cleaner_ratio.
> This commit removes metrics
>  * compaction_failed_initiator_ratio
>  * compaction_failed_cleaner_ratio
> and introduces metrics
>  * compaction_initiator_failure_counter
>  * compaction_cleaner_failure_counter



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to