[
https://issues.apache.org/jira/browse/HIVE-25346?focusedWorklogId=631523&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-631523
]
ASF GitHub Bot logged work on HIVE-25346:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/21 09:32
Start Date: 30/Jul/21 09:32
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2547:
URL: https://github.com/apache/hive/pull/2547#discussion_r679788733
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -1513,6 +1516,11 @@ public void commitTxn(CommitTxnRequest rqst)
} else if (txnType.get() == TxnType.COMPACTION) {
acquireTxnLock(stmt, false);
commitId = getHighWaterMark(stmt);
+ } else if (txnType.get() != TxnType.READ_ONLY && isInsert(stmt,
insertFilter)) {
+ stmt.executeUpdate("INSERT INTO \"WRITE_SET\" (\"WS_DATABASE\",
\"WS_TABLE\", \"WS_PARTITION\", \"WS_TXNID\", \"WS_COMMIT_ID\",
\"WS_OPERATION_TYPE\")" +
+ " SELECT DISTINCT \"TC_DATABASE\", \"TC_TABLE\",
\"TC_PARTITION\", \"TC_TXNID\", " + tempCommitId + ", \"TC_OPERATION_TYPE\" " +
insertFilter);
+ acquireTxnLock(stmt, false);
Review comment:
Why do you need to acquire locks here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 631523)
Time Spent: 2h 40m (was: 2.5h)
> cleanTxnToWriteIdTable breaks SNAPSHOT isolation
> ------------------------------------------------
>
> Key: HIVE-25346
> URL: https://issues.apache.org/jira/browse/HIVE-25346
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Chovan
> Assignee: Zoltan Chovan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
