[
https://issues.apache.org/jira/browse/HIVE-25048?focusedWorklogId=633955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633955
]
ASF GitHub Bot logged work on HIVE-25048:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/21 06:10
Start Date: 05/Aug/21 06:10
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #2441:
URL: https://github.com/apache/hive/pull/2441#discussion_r683080884
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java
##########
@@ -61,6 +66,7 @@ public Result(Object result, int numRetries) {
private final Configuration origConf; // base configuration
private final Configuration activeConf; // active configuration
+ private final List<MetaStoreEndFunctionListener> endFunctionListeners; //
the end function listener
Review comment:
Thank you for the comments!
The `startFunctions` could be eliminated for the reasons listing above,
leaving the `MetaStoreEndFunctionListener` on `endFunction` that should be
taken care of. Introducing a `MetaStoreFunctionListener` makes things much
straightforward, but we can get the context of the current method from
`MetaStoreEndFunctionContext`, making it usless to have an extra start function
listener.
This change also introduce some incompatibility in
[MetaStoreEndFunctionContext](https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreEndFunctionContext.java#L55-L57),
the `getInputTableName` would return null for the old implemention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 633955)
Time Spent: 3h 20m (was: 3h 10m)
> Refine the start/end functions in HMSHandler
> --------------------------------------------
>
> Key: HIVE-25048
> URL: https://issues.apache.org/jira/browse/HIVE-25048
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Some start/end functions are incomplete or wrong in the HMSHandler, these
> functions audit actions, monitor the performance, and notify the end function
> listeners. We have already measured the performance of the HMSHandler in
> PerfLogger, and covered more methods than these functions that have done, so
> we can remove the monitoring from the start/end functions, move the end
> function listeners to the RetryingHMSHandler to eliminate the try-finally
> blocks that spread across many different methods. After these, we can try to
> cleanup the functions to make HMSHandler be more simplified.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
