[
https://issues.apache.org/jira/browse/HIVE-25286?focusedWorklogId=634982&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634982
]
ASF GitHub Bot logged work on HIVE-25286:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/21 07:38
Start Date: 06/Aug/21 07:38
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2427:
URL: https://github.com/apache/hive/pull/2427#discussion_r684017511
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -2420,11 +2464,36 @@ private String timestampAfterSnapshot(Table table, int
snapshotPosition) {
return simpleDateFormat.format(new Date(time));
}
- private void checkColStat(String tableName, String colName) {
+ private void checkColStat(String tableName, String colName, boolean
accurate) {
List<Object[]> rows = shell.executeStatement("DESCRIBE " + tableName + " "
+ colName);
Assert.assertEquals(2, rows.size());
Assert.assertEquals(StatsSetupConst.COLUMN_STATS_ACCURATE, rows.get(1)[0]);
+ Assert.assertEquals(accurate,
!rows.get(1)[1].toString().matches("\\{\\}\\s*"));
Review comment:
Can you add a small comment explaining the regex here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 634982)
Time Spent: 50m (was: 40m)
> Set stats to inaccurate when an Iceberg table is modified outside Hive
> ----------------------------------------------------------------------
>
> Key: HIVE-25286
> URL: https://issues.apache.org/jira/browse/HIVE-25286
> Project: Hive
> Issue Type: New Feature
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When an Iceberg table is modified outside of Hive then the stats should be
> set to inaccurate since there is no way to ensure that the HMS stats are
> updated correctly and this could cause incorrect query results.
> The proposed solution is only working for HiveCatalog
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
