[
https://issues.apache.org/jira/browse/HIVE-25414?focusedWorklogId=636360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636360
]
ASF GitHub Bot logged work on HIVE-25414:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/21 09:40
Start Date: 10/Aug/21 09:40
Worklog Time Spent: 10m
Work Description: maheshk114 commented on a change in pull request #2576:
URL: https://github.com/apache/hive/pull/2576#discussion_r685860041
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
##########
@@ -2871,10 +2871,19 @@ public boolean skipProcessing(Task<?> task) {
Path loadPath = dpCtx.getRootPath();
FileSystem fs = loadPath.getFileSystem(conf);
int numDPCols = dpCtx.getNumDPCols();
- Map<Path, Optional<List<Path>>> allPartition = new HashMap<>();
+ Map<Path, Optional<List<FileStatus>>> allPartition = new HashMap<>();
if (dynamicPartitionSpecs != null) {
for (Map.Entry<String, List<Path>> partSpec :
dynamicPartitionSpecs.entrySet()) {
- allPartition.put(new Path(loadPath, partSpec.getKey()),
Optional.of(partSpec.getValue()));
+ if (Optional.of(partSpec.getValue()).isPresent()) {
Review comment:
I think it's same. I have just changed the data structure to have
FileStatus instead of Path. If path is already null (isPresent is false) ..i am
adding FileStatus as null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 636360)
Time Spent: 0.5h (was: 20m)
> Optimise Hive::addWriteNotificationLog: Reduce FS call per notification
> -----------------------------------------------------------------------
>
> Key: HIVE-25414
> URL: https://issues.apache.org/jira/browse/HIVE-25414
> Project: Hive
> Issue Type: Sub-task
> Reporter: Rajesh Balamohan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> AddWriteNotification is slow due to FS interactions (i.e to get the set of
> insert file information). This can be avoided as FileStatus can be passed
> instead of Path from parent methods.
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L3572]
>
> [https://github.com/apache/hive/blob/96b39cd5190f0cfadb677e3f3b7ead1d663921b2/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L3620]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
