[
https://issues.apache.org/jira/browse/HIVE-25334?focusedWorklogId=636790&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636790
]
ASF GitHub Bot logged work on HIVE-25334:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/21 07:50
Start Date: 11/Aug/21 07:50
Worklog Time Spent: 10m
Work Description: ashish-kumar-sharma commented on a change in pull
request #2482:
URL: https://github.com/apache/hive/pull/2482#discussion_r686585429
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
##########
@@ -434,10 +434,19 @@ protected void obtainTimestampConverter(ObjectInspector[]
arguments, int i,
case TIMESTAMP:
case DATE:
case TIMESTAMPLOCALTZ:
+ case INT:
Review comment:
There data are already implemented in
https://github.com/apache/hive/blob/7b3ecf617a6d46f48a3b6f77e0339fd4ad95a420/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java#L1177.
I am just adding validation check to avoid runtime failures. So no test is
required in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 636790)
Time Spent: 1h 20m (was: 1h 10m)
> Refactor UDF CAST(<Date string> as TIMESTAMP)
> ---------------------------------------------
>
> Key: HIVE-25334
> URL: https://issues.apache.org/jira/browse/HIVE-25334
> Project: Hive
> Issue Type: Sub-task
> Reporter: Ashish Sharma
> Assignee: Ashish Sharma
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Description
> Refactor GenericUDFTimestamp.class
> DOD
> Refactor
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
